Skip to content

OTP language update #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Nov 3, 2022
Merged

OTP language update #7276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9514e
Update Spanish label for "One-time code" field
matthinz Nov 2, 2022
b391379
Update language on "Enter your security code"
matthinz Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/locales/forms/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ es:
two_factor:
backup_code: Código de seguridad
# removed "security code" form labels as they trigger ios credit card reader
code: Código de un solo uso
code: Código único
Copy link
Copy Markdown
Contributor

@aduth aduth Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is used on the IAL1 (authentication) MFA pages, which weren't included in the pull request screenshots.

identity-idp/app/views/two_factor_authentication/otp_verification/show.html.erb

Line 14 in 34f0bcc

<%= label_tag :code, t('forms.two_factor.code'), class: 'display-block text-bold' %>

identity-idp/app/views/two_factor_authentication/totp_verification/show.html.erb

Line 9 in 34f0bcc

<%= label_tag :code, t('forms.two_factor.code'), class: 'display-block text-bold' %>

I think we want to be consistent here (related ticket LG-7932), so maybe not a problem, but flagging in case it wasn't intentional.

Copy link
Copy Markdown
Contributor Author

@matthinz matthinz Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I believe the intention is to update language throughout.

Copy link
Copy Markdown
Contributor

@aduth aduth Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this to the team in Slack and there don't seem to be any concerns, so should be good! (And I agree with being consistent in the language)

personal_key: Clave personal
try_again: Use otro número de teléfono.
validation:
Expand Down
2 changes: 1 addition & 1 deletion config/locales/instructions/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ en:
try_again: try again
sms:
confirm_code_html: Need another code? %{resend_code_link}. Message rates may apply.
number_message_html: We sent a security code to %{number}. This code will expire
number_message_html: We sent a one-time code to %{number}. This code will expire
Copy link
Copy Markdown
Contributor

@aduth aduth Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment, reused in IAL1 (authentication).

identity-idp/app/presenters/two_factor_auth_code/phone_delivery_presenter.rb

Lines 11 to 17 in 34f0bcc

def phone_number_message
t(
"instructions.mfa.#{otp_delivery_preference}.number_message_html",
number: content_tag(:strong, phone_number),
expiration: TwoFactorAuthenticatable::DIRECT_OTP_VALID_FOR_MINUTES,
)
end

in %{expiration} minutes.
voice:
confirm_code_html: Want us to call you again? %{resend_code_link}
Expand Down
4 changes: 2 additions & 2 deletions config/locales/instructions/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ es:
sms:
confirm_code_html: '¿Necesita otro código? %{resend_code_link}. Puede estar
sujeto a cargos de mensajería y datos.'
number_message_html: Enviamos un código de seguridad al %{number}. Este código
caducará en %{expiration} minutos.
number_message_html: Hemos enviado un código único al %{number}. Este código
expirará en %{expiration} minutos.
voice:
confirm_code_html: '¿Desea que le llamemos de nuevo? %{resend_code_link}'
number_message_html: Acabamos de llamarte en %{number}.
Expand Down
4 changes: 2 additions & 2 deletions config/locales/instructions/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ fr:
sms:
confirm_code_html: Vous avez besoin d’un autre code? %{resend_code_link}. Les
frais liés aux messages texte peuvent s’appliquer.
number_message_html: Nous avons envoyé un code de sécurité au %{number}. Ce code
expirera dans %{expiration} minutes.
number_message_html: Nous avons envoyé un code à usage unique au %{number}. Ce
code expirera dans %{expiration} minutes.
voice:
confirm_code_html: Vous voulez que nous vous appelions de nouveau? %{resend_code_link}
number_message_html: Nous venons de vous appeler à %{number}.
Expand Down
2 changes: 1 addition & 1 deletion config/locales/titles/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ en:
cancellation_prompt: Cancel identity verification
cancelled: Identity verification is cancelled
come_back_soon: Come back soon
enter_security_code: Enter your security code
enter_security_code: Enter your one-time code
Copy link
Copy Markdown
Contributor

@aduth aduth Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing the text from "security code" to "one-time code", I think it'd be clearer if we updated the key accordingly.

Suggested change
enter_security_code: Enter your one-time code
enter_one_time_code: Enter your one-time code

Copy link
Copy Markdown
Contributor Author

@matthinz matthinz Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I hit merge too eagerly. I agree with this & will follow up.

get_letter: Get a letter
personal_key: Save your personal key
phone: Verify your phone number
Expand Down
2 changes: 1 addition & 1 deletion config/locales/titles/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ es:
cancellation_prompt: Cancela la verificación de identidad
cancelled: Se canceló la verificación de identidad
come_back_soon: Vuelve pronto
enter_security_code: Ingresa tu código de seguridad
enter_security_code: Introduzca su código único
get_letter: Recibe una carta
personal_key: Guarda tu llave personal
phone: Verifica tu número telefónico
Expand Down
2 changes: 1 addition & 1 deletion config/locales/titles/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ fr:
cancellation_prompt: Annulez la vérification d’identité
cancelled: La vérification d’identité est annulée
come_back_soon: Revenez bientôt
enter_security_code: Entrez votre code de sécurité
enter_security_code: Entrez votre code à usage unique
get_letter: Obtenez une lettre
personal_key: Enregistrez votre clé personnelle
phone: Vérifiez votre numéro de téléphone
Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ en:
backup_code_prompt: You can use this security code once. After you enter it,
you’ll need to use a new key.
choose_another_option: '‹ Choose another option'
header_text: Enter your security code
header_text: Enter your one-time code
important_alert_icon: important alert icon
invalid_backup_code: That backup code is invalid.
invalid_otp: That security code is invalid. You can try entering it again or
Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ es:
backup_code_prompt: Puede utilizar este código de seguridad una vez. Después de
ingresarlo, deberá usar una nueva clave.
choose_another_option: '‹ Elige otra opción'
header_text: Ingrese su código de seguridad
header_text: Introduzca su código único
important_alert_icon: ícono de aviso importante
invalid_backup_code: Esa código de respaldo no es válida.
invalid_otp: Ese código de seguridad no es válido. Puede intentar ingresarlo de
Expand Down
2 changes: 1 addition & 1 deletion config/locales/two_factor_authentication/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ fr:
backup_code_prompt: Vous pouvez utiliser ce code de sécurité une fois. Après
l’avoir entré, vous devrez utiliser une nouvelle clé.
choose_another_option: '‹ Choisissez une autre option'
header_text: Entrez votre code de sécurité
header_text: Entrez votre code à usage unique
important_alert_icon: Icône d’alerte importante
invalid_backup_code: Ce code de sauvegarde est invalide.
invalid_otp: Ce code de sécurité est non valide. Vous pouvez essayer de l’entrer
Expand Down