Merged
Conversation
* Remove Unnecessary Success parameters changelog: Internal, Attempts API, Standardize events
* Enforce and fix attribute expectations for analytics spec changelog: Internal, Automated Testing, Improve accuracy of analytics regression specs * Add missing review step events in analytics happy path * Add completed GPO steps expected events
* changelog: Internal, Analytics, Only populate registration_logs for final step
…s associated with account (#7095) * do not display "manage phone number" if a user only has one phone method * add method that returns boolean for 1 phone method configuered * add test to reflect change in default text on account screen * add switch to display text when user only has 1 phone method set up * add logic and text for default number instructions * add and edit supporting tests changelog: Improvements, UX, disable checkbox when only one phone number is set * remove unused code * add missing french keys * address lint errors * Address PR comments-edit text and re-work test * write a test to test one_phone_configuration method * fix test for edit form spec
* changelog: Improvements, In-Person Proofing, troubleshooting-options now use an explicit divider prop * Rename divider; use better dynamic classes pattern * Include test for new divider prop
…ut keeps refactoring of troubleshooting-options (#7134)
changelog: Internal, Emails, Move report emails into separate Mailer
**Why**: It may not be helping the reports run faster, and it may be making the pg connections more fragile/stateful * Rescue PG::ConnectionBad too [skip changelog]
aduth
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Internal