Conversation
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
from
9033bfe to
525a317
Compare
jmdembe
changed the title
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
2 times, most recently
from
e2ed402 to
ca0ea52
Compare
mdiarra3
reviewed
Oct 6, 2022
app/views/accounts/_phone.html.erb
Outdated
Contributor
There was a problem hiding this comment.
Do we have an issue with phone showing default even if its just one? or do we think its not needed information.
Contributor
Author
There was a problem hiding this comment.
Based on the design, it was deemed as not needing that information
aduth
reviewed
Oct 6, 2022
app/forms/edit_phone_form.rb
Outdated
Contributor
There was a problem hiding this comment.
The EditPhoneForm class doesn't currently have great test coverage for its methods, but could we try adding some for this new method?
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
2 times, most recently
from
c5a8707 to
fcb2522
Compare
changelog: Improvements, UX, disable checkbox when only one phone number is set
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
from
fcb2522 to
32efa09
Compare
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
3 times, most recently
from
d18c478 to
cccdfef
Compare
jmdembe
force-pushed
the
LG-4258-default-phone-number
branch
from
cccdfef to
72bccd2
Compare
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
…s associated with account (#7095) * do not display "manage phone number" if a user only has one phone method * add method that returns boolean for 1 phone method configuered * add test to reflect change in default text on account screen * add switch to display text when user only has 1 phone method set up * add logic and text for default number instructions * add and edit supporting tests changelog: Improvements, UX, disable checkbox when only one phone number is set * remove unused code * add missing french keys * address lint errors * Address PR comments-edit text and re-work test * write a test to test one_phone_configuration method * fix test for edit form spec
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-4258
🛠 Summary of changes
If a user has only one phone number set up on their account, they should not be able to select or deselect the "Make default number" checkbox. With this change, the checkbox will be disabled when there is one number associated with an account as well as a messaging that lays out why they cannot change their default number.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
🚀 Notes for Deployment
N/A