7683 Revert IPP CTA change (while preserving troubleshooting-options refactor)#7134
Merged
allthesignals merged 1 commit intomainfrom Oct 12, 2022
Merged
Conversation
aduth
approved these changes
Oct 12, 2022
…ut keeps refactoring of troubleshooting-options
allthesignals
force-pushed
the
wmg/7683-ipp-move-up-reversion
branch
from
3532e5f to
2f93fe7
Compare
allthesignals
changed the title
aduth
approved these changes
Oct 12, 2022
allthesignals
commented
Oct 12, 2022
| heading={formatHTML(t('idv.troubleshooting.headings.are_you_near'), { | ||
| wbr: 'wbr', | ||
| })} | ||
| divider={false} |
Contributor
Author
There was a problem hiding this comment.
Note that this uses the new divider={false} prop to preserve intended behavior
This was referenced Oct 12, 2022
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
…ut keeps refactoring of troubleshooting-options (#7134)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket.
#7129
https://cm-jira.usa.gov/browse/LG-7683
🛠 Summary of changes
This reverts commit feb84af. I was supposed to leave this as an open PR until designers were ready to merge this.This change reverts some of feb84af. We will keep changes to troubleshooting-options, but hold off on moving up the IPP CTA.
👀 Screenshots
Before:
After: