Skip to content

changelog: Improvements, Authentication, Update from cancel to skip for now #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdiarra3 merged 3 commits into from
Sep 27, 2022
Merged

changelog: Improvements, Authentication, Update from cancel to skip for now #7025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35bb163
changelog: Improvements, Authentication, Update from cancel to skip f…
mdiarra3 Sep 26, 2022
3f40a04
update spec
mdiarra3 Sep 26, 2022
045ab1e
remove unneeded class
mdiarra3 Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/views/users/mfa_selection/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
<%= f.submit t('forms.buttons.continue'), class: 'margin-bottom-1' %>
<% end %>

<%= render 'shared/cancel', link: @after_setup_path %>
<%= render PageFooterComponent.new do %>
<%= link_to t('mfa.skip'), @after_setup_path, method: :get %>
<% end %>

<%= javascript_packs_tag_once('webauthn-unhide') %>
4 changes: 2 additions & 2 deletions spec/features/two_factor_authentication/multiple_mfa_sign_up_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
expect(current_path).to eq account_path
end

scenario 'user can select 1 MFA methods and cancels selecting second mfa' do
scenario 'user can select 1 MFA methods and skips selecting second mfa' do
sign_in_before_2fa

expect(current_path).to eq authentication_methods_setup_path
Expand All @@ -135,7 +135,7 @@

expect(page).to have_current_path(second_mfa_setup_path)

click_link t('links.cancel')
click_link t('mfa.skip')

expect(page).to have_current_path(account_path)
end
Expand Down