Skip to content

Limit selection of sign in events to 2 when fetching second_last_signed_in_at #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 19, 2022
Merged

Limit selection of sign in events to 2 when fetching second_last_signed_in_at #6979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/decorators/user_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def devices?

def second_last_signed_in_at
user.events.where(event_type: 'sign_in_after_2fa').
order(created_at: :desc).pluck(:created_at).second
order(created_at: :desc).limit(2).pluck(:created_at).second
end

def connected_apps
Expand Down
11 changes: 11 additions & 0 deletions spec/decorators/user_decorator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,4 +338,15 @@
expect(user_decorator.connected_apps).to eq([app])
end
end

describe '#second_last_signed_in_at' do
it 'returns second most recent full authentication event' do
user = create(:user)
_event1 = create(:event, user: user, event_type: 'sign_in_after_2fa')
event2 = create(:event, user: user, event_type: 'sign_in_after_2fa')
_event3 = create(:event, user: user, event_type: 'sign_in_after_2fa')

expect(user.decorate.second_last_signed_in_at).to eq(event2.reload.created_at)
end
end
end