Add regression spec for redaction in ResolutionProofingJob#6905
Merged
zachmargolis merged 2 commits intojskinne3-json-nil-guardfrom Sep 1, 2022
Merged
Add regression spec for redaction in ResolutionProofingJob#6905zachmargolis merged 2 commits intojskinne3-json-nil-guardfrom
zachmargolis merged 2 commits intojskinne3-json-nil-guardfrom
Conversation
jskinne3
approved these changes
Sep 1, 2022
| end | ||
|
|
||
| context 'nil response body from ddp' do | ||
| let(:ddp_result) { Proofing::Result.new } |
Contributor
There was a problem hiding this comment.
I think it would be nice to explain in a comment that the response_body tacitly becomes nil here
jskinne3
added a commit
that referenced
this pull request
Sep 1, 2022
* guard against non-hash arg input * Add tests for logging redactor * changelog: Internal, ThreatMetrix API, redacted logging tests * Remove misnamed file * Lint * Document nil as an expected value with YARD * Style suggestions in spec file * Add regression spec for redaction in ResolutionProofingJob (#6905) * Add regression spec for redaction in ResolutionProofingJob * Add constructor to clarify nil response_body Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
stevegsa
reviewed
Sep 1, 2022
| @exception = exception | ||
| @transaction_id = transaction_id | ||
| @reference = reference | ||
| @response_body = response_body |
Contributor
There was a problem hiding this comment.
regretting I named this response_body since it's a hash
Contributor
Author
There was a problem hiding this comment.
It's just code, we can always rename it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small add-on to #6903