guard against non-hash arg input

[jskinne3]

addressing undefined method 'slice' for nil:NilClass error in log redacter

Error observed in NewRelic

changelog: Internal, ThreatMetrix API, redacted logging tests

[aduth]

Should we update the parameter type if we're expecting nil or other non-hash values?

[jskinne3]

I'm only expecting those values in error situations; they are not the way that the method is intended to be used. So, I would say no, non-hash values should not be documented because they're not supposed to be used. But, I could see the argument the other way, too.

[zachmargolis]

I think an array would be a not-expected value, but I do think nil is sort of expected, so I'd at least document that

[aduth]

I think if we're handling those other value types in this method, they are supported types for the method. And if we don't want them to be supported types, we shouldn't call the method with those values.

[zachmargolis]

same, I think the whole body would be easier to see

Suggested change

	it 'redacts unknown keys' do
	expect(json.values).to eq(['safe value']*3)
	end
	it 'allows known keys' do
	expect(json).to eq(
	'review_status' => 'safe value',
	'summary_risk_score' => 'safe value',
	'fraudpoint.score' => 'safe value'
	)
	end

and maybe even combining this spec with the above? One body that has both known + unknown keys?

[zachmargolis]

LGTM!

[stevegsa]

typo

[jskinne3]

I am unsuccessful in reopening this PR

[stevegsa]

Looks great!