Skip to content

Add regression spec for redaction in ResolutionProofingJob #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 2 commits into from
Sep 1, 2022
Merged

Add regression spec for redaction in ResolutionProofingJob #6905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffa0da5
Add regression spec for redaction in ResolutionProofingJob
zachmargolis Sep 1, 2022
a9f4b48
Add constructor to clarify nil response_body
zachmargolis Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/services/proofing/result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ def initialize(
context: {},
exception: nil,
transaction_id: nil,
reference: nil
reference: nil,
response_body: nil
)
@errors = errors
@context = context
@exception = exception
@transaction_id = transaction_id
@reference = reference
@response_body = response_body
Copy link
Copy Markdown
Contributor

@stevegsa stevegsa Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regretting I named this response_body since it's a hash

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just code, we can always rename it

end

# rubocop:disable Style/OptionalArguments
Expand Down
19 changes: 19 additions & 0 deletions spec/jobs/resolution_proofing_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
let(:state_id_proofer) do
instance_double(Proofing::Aamva::Proofer, class: Proofing::Aamva::Proofer)
end
let(:ddp_proofer) { Proofing::Mock::DdpMockClient.new }
let(:trace_id) { SecureRandom.uuid }
let(:user) { create(:user, :signed_up) }
let(:threatmetrix_session_id) { SecureRandom.uuid }
Expand Down Expand Up @@ -256,6 +257,7 @@
before do
allow(instance).to receive(:resolution_proofer).and_return(resolution_proofer)
allow(instance).to receive(:state_id_proofer).and_return(state_id_proofer)
allow(instance).to receive(:lexisnexis_ddp_proofer).and_return(ddp_proofer)
allow(IdentityConfig.store).to receive(:lexisnexis_threatmetrix_enabled).
and_return(true)
end
Expand Down Expand Up @@ -292,6 +294,23 @@
expect(proofing_component.threatmetrix).to equal(true)
expect(proofing_component.threatmetrix_review_status).to eq('pass')
end

context 'nil response body from ddp' do
let(:ddp_result) { Proofing::Result.new(response_body: nil) }

before do
expect(ddp_proofer).to receive(:proof).and_return(ddp_result)
end

it 'does not blow up' do
perform

result = document_capture_session.load_proofing_result[:result]

expect(result[:context][:stages][:threatmetrix][:response_body]).
to eq(error: 'TMx response body was empty')
end
end
end

context 'does not call state id with an unsuccessful response from the proofer' do
Expand Down