LG-6434: Create template for "Your identity could not be verified" email, and send when status is set to failed#6676
Merged
tomas-nava merged 14 commits intoshannon/lg-6341-verified-identity-emailfrom Aug 2, 2022
Conversation
tomas-nava
changed the title
Required by tests for single point of update
aduth
approved these changes
Aug 2, 2022
| <%= link_to idv_url, idv_url, target: '_blank', rel: 'noopener' %> | ||
| </p> | ||
|
|
||
| <div class="s16"> |
Contributor
There was a problem hiding this comment.
Separately we should consider changing the default font size for all emails, so we're not applying them to individual templates like this.
| </div> | ||
|
|
||
| <p> | ||
| <%= link_to idv_url, idv_url, target: '_blank', rel: 'noopener' %> |
Contributor
There was a problem hiding this comment.
Just to note, we're telling the user to follow these links to "try again", but unless the user is already signed in when they visit /verify, they would be presented with the sign in page, and we don't currently redirect the user to their original intended destination (LG-3737), so they would arrive at their account page after signing in.
kellular
approved these changes
Aug 2, 2022
kellular
left a comment
kellular
left a comment
There was a problem hiding this comment.
Cross-checked the screenshot with the Figma file. This LGTM
tomas-nava
deleted the
shannon/lg-6434-failed-identity-email-clean-rebase
branch
tomas-nava
pushed a commit
that referenced
this pull request
Aug 2, 2022
… set to passed (#6665) * add styles to email stylesheet * add heading strings * add verified email strings * add route * create verified email and show in preview * add send verified email to jobs * lint fix * fix urls? and normalize yaml * can hide title in layout, added to new template * use rasterized header image & add padding * use the standard email button size * use existing sample enrollment data for preview * send email in job, remove user's first name * rename presenter methods * tests * add changelog changelog: Upcoming Features, In-Person Proofing, Implement "You verified" email notification * fix i18n test failures * LG-6434: Create template for "Your identity could not be verified" email, and send when status is set to failed (#6676) * add strings * fr strings added * refactor presenter * add failure email ui * update spec to use refactored presenter * failure email * normalize yaml, split list into steps * email styles: no header image, bold list opener * mover lower part of both emails into a partial * Interpolate app_name Required by tests for single point of update * styling changes Co-authored-by: Shannon Alexander <shannonalexander@Shannons-MBP.fios-router.home> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Shannon Alexander <shannonalexander@Shannons-MBP.fios-router.home> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a public user who's visited a Post Office to be proofed in person, I want to know whether or not I was successfully proofed.
Testing instructions:
Screenshot