LG-6341: Create template for success email and send it when status is set to passed#6665
Merged
tomas-nava merged 19 commits intomainfrom Aug 2, 2022
Merged
Conversation
tomas-nava
commented
Aug 1, 2022
tomas-nava
commented
Aug 1, 2022
| </table> | ||
| <h4><%= @header || message.subject %> | ||
| </h4><%= yield %> | ||
| <% unless @hide_title %> |
Contributor
Author
There was a problem hiding this comment.
I'm doing this so we can render the image above the title
changelog: Upcoming Features, In-Person Proofing, Implement "You verified" email notification
svalexander
reviewed
Aug 1, 2022
svalexander
reviewed
Aug 1, 2022
|
LGTM! 🎉 |
…ied-identity-email
tomas-nava
changed the title
aduth
approved these changes
Aug 2, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM, comments are minor and non-blocking 👍
Comment on lines
+4
to
+5
| # update to user's time zone when out of pilot | ||
| USPS_SERVER_TIMEZONE = ActiveSupport::TimeZone['America/New_York'] |
Contributor
There was a problem hiding this comment.
It's a problem we can sort out later, but I'm wondering how we'll know what the user's timezone is. I don't think we record this preference anywhere.
…ail, and send when status is set to failed (#6676) * add strings * fr strings added * refactor presenter * add failure email ui * update spec to use refactored presenter * failure email * normalize yaml, split list into steps * email styles: no header image, bold list opener * mover lower part of both emails into a partial * Interpolate app_name Required by tests for single point of update * styling changes Co-authored-by: Shannon Alexander <shannonalexander@Shannons-MBP.fios-router.home> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a public user who's visited a Post Office to be proofed in person, I want to know whether I was successfully proofed.
Testing instructions:
Screenshot