-
Notifications
You must be signed in to change notification settings - Fork 166
LG-6434: Create template for "Your identity could not be verified" email, and send when status is set to failed #6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tomas-nava
merged 14 commits into
shannon/lg-6341-verified-identity-email
from
shannon/lg-6434-failed-identity-email-clean-rebase
Aug 2, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c89c2a8
add strings
665e854
fr strings added
3f92fbe
refactor presenter
c9f8fb6
add failure email ui
3e400b4
update spec to use refactored presenter
bd311c8
failure email
1d1b857
normalize yaml, split list into steps
1b25428
email styles: no header image, bold list opener
208c8b6
rename presenter
5f3f508
rename method
cf65631
tests
97bad07
mover lower part of both emails into a partial
543e6bf
Interpolate app_name
aduth e87a197
styling changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...nters/idv/in_person/verified_presenter.rb → ...n/verification_results_email_presenter.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
app/views/shared/_in-person-verification-results-email-lower.html.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <div class="margin-top-5"> | ||
| <table class="button expanded large radius"> | ||
| <tbody> | ||
| <tr> | ||
| <td> | ||
| <table> | ||
| <tbody> | ||
| <tr> | ||
| <td style="text-align: center"> | ||
| <%= link_to t('user_mailer.in_person_verified.sign_in'), | ||
| idv_url, | ||
| target: '_blank', | ||
| class: 'float-center', | ||
| rel: 'noopener' %> | ||
| </td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| </td> | ||
| <td class="expander"></td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| </div> | ||
|
|
||
| <p> | ||
| <%= link_to idv_url, idv_url, target: '_blank', rel: 'noopener' %> | ||
| </p> | ||
|
|
||
| <div class="s16"> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Separately we should consider changing the default font size for all emails, so we're not applying them to individual templates like this. |
||
| <br /> | ||
| <%= t( | ||
| 'user_mailer.in_person_verified.warning_contact_us_html', | ||
| contact_us_url: MarketingSite.contact_url, | ||
| sign_in_url: idv_url, | ||
| ) | ||
| %> | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <div class="s16"> | ||
| <%= t('user_mailer.in_person_verified.greeting') %><br> | ||
| <p class="s16"> | ||
| <%= t( | ||
| 'user_mailer.in_person_failed.intro', | ||
| location: @presenter.location_name, | ||
| date: @presenter.formatted_verified_date, | ||
| ) %> | ||
| </p> | ||
| <p class="s16"> | ||
| <%= t('user_mailer.in_person_failed.body', app_name: APP_NAME) %><br><br /> | ||
| </p> | ||
| <strong><%= t('user_mailer.in_person_failed.verifying_identity') %></strong><br> | ||
| <ul class="usa-list"> | ||
| <li><%= t('user_mailer.in_person_failed.verifying_step_not_expired') %></li> | ||
| <li><%= t('user_mailer.in_person_failed.verifying_step_proof_of_address') %></li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <%= render 'shared/in-person-verification-results-email-lower' %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../idv/in_person/verified_presenter_spec.rb → ...ification_results_email_presenter_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to note, we're telling the user to follow these links to "try again", but unless the user is already signed in when they visit
/verify, they would be presented with the sign in page, and we don't currently redirect the user to their original intended destination (LG-3737), so they would arrive at their account page after signing in.