Remove CircleCI

[mitchellhenke]

With #6614 live, we should be able to drop CircleCI if we want 🙂

[zachmargolis]

🌶️ ooo spicy

[aduth]

There's a handful of other references to CircleCI, should we clean those up as well?

$ ag circleci -i --ignore-dir=node_modules
config/environments/test.rb
39:  # Disable lograge when computing coverage and not in CircleCI, where lograge is required.

spec/simplecov_helper.rb
64:      # CircleCI uses JSON formatting for CodeClimate

README.md
4:[![Build Status](https://circleci.com/gh/18F/identity-idp.svg?style=svg)](https://circleci.com/gh/18F/identity-idp)

$ ag circle_ci -i --ignore-dir=node_modules
spec/simplecov_helper.rb
63:    elsif ENV['CIRCLE_CI']

[aduth]

Just to clarify, is the intention to keep this around? I would have expected the config to be removed altogether.

[mitchellhenke]

Nope. The real step is to click the big red button on the CircleCI website, I just wanted this to be green for now since CircleCI complained when I deleted the file.

[mitchellhenke]

There's a handful of other references to CircleCI, should we clean those up as well?

$ ag circleci -i --ignore-dir=node_modules
config/environments/test.rb
39:  # Disable lograge when computing coverage and not in CircleCI, where lograge is required.

spec/simplecov_helper.rb
64:      # CircleCI uses JSON formatting for CodeClimate

README.md
4:[![Build Status](https://circleci.com/gh/18F/identity-idp.svg?style=svg)](https://circleci.com/gh/18F/identity-idp)

$ ag circle_ci -i --ignore-dir=node_modules
spec/simplecov_helper.rb
63:    elsif ENV['CIRCLE_CI']

thank you for catching, deleted these

[aduth]

Just to confirm, should we still be enabling this given the other half of the condition?

Suggested change

	# Disable lograge when computing coverage and not in CircleCI, where lograge is required.
	# This enables scanning for view test coverage with `rake test:scan_log_for_view_coverage`
	config.lograge.enabled = !ENV['COVERAGE'] || ENV['CI']
	# Disable lograge when computing coverage, where lograge is required.
	# This enables scanning for view test coverage with `rake test:scan_log_for_view_coverage`
	config.lograge.enabled = !ENV['COVERAGE']

[mitchellhenke]

It didn't impact the current coverage calculation (https://gitlab.login.gov/lg/identity-idp/-/jobs/51849), so it seems ok for now.