Skip to content

Remove CircleCI #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Aug 18, 2022
Merged

Remove CircleCI #6671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9583647
Remove CircleCI
Aug 1, 2022
5c64da9
remove other stuff
Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
300 changes: 0 additions & 300 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
Login.gov Identity Provider (IdP)
=================================

[![Build Status](https://circleci.com/gh/18F/identity-idp.svg?style=svg)](https://circleci.com/gh/18F/identity-idp)
[![Code Climate](https://api.codeclimate.com/v1/badges/e78d453f7cbcac64a664/maintainability)](https://codeclimate.com/github/18F/identity-idp/maintainability)
[![Test Coverage](https://api.codeclimate.com/v1/badges/e78d453f7cbcac64a664/test_coverage)](https://codeclimate.com/github/18F/identity-idp/test_coverage)

Login.gov is the public's one account for government. Use one account and password for secure, private access to participating government agencies.

This repository contains the core code base and documentation for the identity management system powering secure.login.gov.
Expand Down
4 changes: 0 additions & 4 deletions config/environments/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@

config.middleware.use RackSessionAccess::Middleware

# Disable lograge when computing coverage and not in CircleCI, where lograge is required.
# This enables scanning for view test coverage with `rake test:scan_log_for_view_coverage`
config.lograge.enabled = !ENV['COVERAGE'] || ENV['CI']
Comment on lines -39 to -41
Copy link
Copy Markdown
Contributor

@aduth aduth Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, should we still be enabling this given the other half of the condition?

Suggested change
# Disable lograge when computing coverage and not in CircleCI, where lograge is required.
# This enables scanning for view test coverage with `rake test:scan_log_for_view_coverage`
config.lograge.enabled = !ENV['COVERAGE'] || ENV['CI']
# Disable lograge when computing coverage, where lograge is required.
# This enables scanning for view test coverage with `rake test:scan_log_for_view_coverage`
config.lograge.enabled = !ENV['COVERAGE']

Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't impact the current coverage calculation (https://gitlab.login.gov/lg/identity-idp/-/jobs/51849), so it seems ok for now.


config.after_initialize do
# Having bullet enabled in the test environment causes issues with unit
# tests that may not make user of eager loaded values. We disable it by
Expand Down
3 changes: 0 additions & 3 deletions spec/simplecov_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ def self.configured_formatters
if ENV['GITLAB_CI']
# GitLab CI uses Cobertura formatter to display diffs in pull requests
formatters << SimpleCov::Formatter::CoberturaFormatter
elsif ENV['CIRCLE_CI']
# CircleCI uses JSON formatting for CodeClimate
formatters << SimpleCov::Formatter::JSONFormatter
end

formatters
Expand Down