Conversation
added 4 commits
July 21, 2022 13:06
sheldon-b
commented
Jul 21, 2022
Comment on lines
+99
to
+118
| selected_location_details: { | ||
| 'name' => 'BALTIMORE — Post Office™', | ||
| 'streetAddress' => '900 E FAYETTE ST RM 118', | ||
| 'city' => 'BALTIMORE', | ||
| 'state' => 'MD', | ||
| 'zip5' => '21233', | ||
| 'zip4' => '9715', | ||
| 'phone' => '555-123-6409', | ||
| 'hours' => [ | ||
| { | ||
| 'weekdayHours' => '8:30 AM - 4:30 PM', | ||
| }, | ||
| { | ||
| 'saturdayHours' => '9:00 AM - 12:00 PM', | ||
| }, | ||
| { | ||
| 'sundayHours' => 'Closed', | ||
| }, | ||
| ], | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This is a temporary solution. Once the user's location selection is saved to the session we will begin using that value instead of this hard-coded value
sheldon-b
requested review from
a team and
tomas-nava
and removed request for
a team
sheldon-b
changed the title
tomas-nava
approved these changes
Jul 22, 2022
Contributor
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
approve!
If it's easy, I think it'd be worth setting current_address_matches_id when we create the enrollment; if it's a lot of work, we can do it in a new ticket/PR.
sheldon-b
deleted the
sbachstein/lg-6872-make-barcode-use-users-enrollment-code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6615 made it so that when a user completes the IPP flow we will create a pending in-person enrollment record with the enrollment code we receive from the USPS. This PR updates the "Ready to verify" page to use that enrollment code rather than using a hard-coded value