-
Notifications
You must be signed in to change notification settings - Fork 166
LG-6872: Create USPS barcode using the user's enrollment code #6619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sheldon-b
merged 6 commits into
main
from
sbachstein/lg-6872-make-barcode-use-users-enrollment-code
Jul 22, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
37a20c5
Use user's enrollment to generate barcode
77e5e78
Don't hard-code enrollment values
9c9613f
Use the correct fixture to unbreak feature test
e9f2d8d
changelog: Upcoming features, In-person proofing, use the real USPS e…
9454543
Make sure enrollment has an appropriate profile
4291c72
Persist current_address_same_as_id
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,27 @@ def save_in_person_enrollment(user, profile) | |
| enrollment = InPersonEnrollment.create!( | ||
| profile: profile, | ||
| user: user, | ||
| current_address_matches_id: user_session.dig(:idv, :applicant, :same_address_as_id), | ||
| selected_location_details: { | ||
| 'name' => 'BALTIMORE — Post Office™', | ||
| 'streetAddress' => '900 E FAYETTE ST RM 118', | ||
| 'city' => 'BALTIMORE', | ||
| 'state' => 'MD', | ||
| 'zip5' => '21233', | ||
| 'zip4' => '9715', | ||
| 'phone' => '555-123-6409', | ||
| 'hours' => [ | ||
| { | ||
| 'weekdayHours' => '8:30 AM - 4:30 PM', | ||
| }, | ||
| { | ||
| 'saturdayHours' => '9:00 AM - 12:00 PM', | ||
| }, | ||
| { | ||
| 'sundayHours' => 'Closed', | ||
| }, | ||
| ], | ||
| }, | ||
|
Comment on lines
+100
to
+119
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a temporary solution. Once the user's location selection is saved to the session we will begin using that value instead of this hard-coded value |
||
| ) | ||
|
|
||
| enrollment_code = create_usps_enrollment(enrollment) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.