LG-6872: Creation USPS enrollment when IPP user re-enters their password by sheldon-b · Pull Request #6615 · 18F/identity-idp

sheldon-b · 2022-07-21T00:36:00Z

Begins creating USPS enrollments for user who complete the in-person proofing flow

When a user re-enters their password after completing the in-person proofing flow we create an InPersonProofingEnrollment record and make an API request to enroll the user in USPS IPPaaS
Adds a mock_usps_fallback feature flag which, when active (which is the default), causes the application not to make real requests to the USPS API
Adds a new UspsInPersonProofing module with a mock proofer. Moves the existing proofer into this module

📋 Future work

There are several chunks of work that I didn't have time to complete in this first PR. I'm hoping that we can merge this PR the morning of 7/21/2022 so that we can use it to bug bash and then continue to flesh this work out in a future PR.

Error handling for when requests to the USPS IPPaaS return errors or unexpected data
Showing error indicators to the user when USPS IPPaaS requests fail
Sending the user's address2 information to USPS

Broken -- tries to call the real USPS which we don't have configured

…eate-usps-enrollment-in-ipp-flow

…llments in USPS api when user completes flow

sheldon-b · 2022-07-21T05:39:28Z

app/controllers/api/verify/password_confirm_controller.rb

+            first_name: pii.first_name,
+            last_name: pii.last_name,
+            address: pii.address1,
+            # do we need address2?


We do, I just didn't have time to add it in this PR. Will add in a follow-up

sheldon-b · 2022-07-21T05:40:10Z

app/controllers/api/verify/password_confirm_controller.rb

+        response = proofer.request_enroll(applicant)
+        response['enrollmentCode']


I'm planning on adding error handling in a follow-up PR

WDYT of creating a Struct-like object to repesent the response here so we could do a direct property access response.enrollment_code rather than digging into a hash? Makes mocking responses easier as well

sheldon-b · 2022-07-21T05:40:57Z

app/models/in_person_enrollment.rb

  # Returns the value to use for the USPS enrollment ID
  def usps_unique_id
-    user_id.to_s
+    user.uuid.delete('-').slice(0, 18)


This is just a temporary solution. There's a separate ticket to think through the best way to generate unique IDs

sheldon-b · 2022-07-21T05:42:09Z

app/services/usps_in_person_proofing/proofer.rb

@@ -0,0 +1,182 @@
+module UspsInPersonProofing


I just moved this file and moved the class into a module. The namespace and class name have changed but otherwise this is unchanged

Should move & rename the test file as well, from

spec/services/usps_in_person_proofer_spec.rb

to

spec/services/usps_in_person_proofing/proofer_spec.rb

zachmargolis · 2022-07-21T15:17:18Z

app/controllers/api/verify/password_confirm_controller.rb

+        response = proofer.request_enroll(applicant)
+        response['enrollmentCode']


WDYT of creating a Struct-like object to repesent the response here so we could do a direct property access response.enrollment_code rather than digging into a hash? Makes mocking responses easier as well

zachmargolis · 2022-07-21T15:17:52Z

app/controllers/api/verify/password_confirm_controller.rb

+        enrollment = InPersonEnrollment.create!(
+          profile: profile,
+          user: user,
+        )


so I had a thought I dropped in slack this morning about maybe we flip the order of these.. could be a future PR if needed!

tomas-nava

approve! with some non-blocking comments & suggestions

I do wonder if there's a better way to name & organize the proofing modules & structs, but this works for now.

tomas-nava · 2022-07-21T15:13:58Z

app/controllers/api/verify/password_confirm_controller.rb

@@ -59,6 +60,52 @@ def in_person_enrollment?(user)
        # WILLFIX: After LG-6872 and we have enrollment saved, reference enrollment instead.


Anything we need to think about here? I think the assumption at the time this was written was that we might create an enrollment earlier in the process.

I think it's fine as-is. This method gets used twice: once before the enrollment is created and once after. The enrollment is only a useful indicator of this being an in-person flow after it is created

I'm going to leave it as-is in this file and will begin using the enrollment on the next page, in the personal key controller

tomas-nava · 2022-07-21T15:29:10Z

app/controllers/api/verify/password_confirm_controller.rb

+        # update the enrollment to status pending
+        enrollment.enrollment_code = enrollment_code
+        enrollment.status = :pending
+        enrollment.save!


Will need error handling here too, in case there's an existing pending enrollment.

tomas-nava · 2022-07-21T15:31:13Z

app/services/usps_in_person_proofing/proofer.rb

@@ -0,0 +1,182 @@
+module UspsInPersonProofing


Should move & rename the test file as well, from

spec/services/usps_in_person_proofer_spec.rb

to

spec/services/usps_in_person_proofing/proofer_spec.rb

sheldon-b · 2022-07-21T16:18:25Z

Thanks for the reviews! I'm going to merge this so we can use it in bug bash and I'll address all of the comments in a separate PR

Sheldon Bachstein added 22 commits July 15, 2022 10:22

Prepping to create USPS enrollment

6511542

Begin calling usps

73e9d7b

Broken -- tries to call the real USPS which we don't have configured

Add mock USPS proofer and create enrollment

bdd23ad

Add mock service

3069b5e

Move usps integration to password controller

3265654

Merge remote-tracking branch 'origin/main' into sbachstein/lg-6872-cr…

9c24677

…eate-usps-enrollment-in-ipp-flow

Use a more unique unique_id

05dd575

Add usps in person proofing directory

0d6020a

Move structs into usps proofing directory

c978301

Fix broken specs

1a722ab

Move and simplify

15c1a4c

Merge remote-tracking branch 'origin/main' into sbachstein/lg-6872-cr…

54418f9

…eate-usps-enrollment-in-ipp-flow

Fix lint failures

948968d

Use a different unique ID

1a2b6e6

Reorganize enrollment creation logic

53b6101

Remove unused changes

1df16b0

Flesh out specs

07d69f7

Use new namespace and name

c78d47e

changelog: Upcoming features, In-person proofing, Begin creating enro…

5a7b661

…llments in USPS api when user completes flow

Reorganize specs and code

ee75065

Add another spec, remove some todos

e47cdc7

Remove unnecessary code and comments

20a4891

sheldon-b commented Jul 21, 2022

View reviewed changes

Slight refactor

cce86be

sheldon-b changed the title ~~(WIP) LG-6872: Creation USPS enrollment when IPP user re-enters their password~~ LG-6872: Creation USPS enrollment when IPP user re-enters their password Jul 21, 2022

sheldon-b marked this pull request as ready for review July 21, 2022 05:58

sheldon-b requested a review from a team July 21, 2022 15:00

sheldon-b requested review from tomas-nava and zachmargolis July 21, 2022 15:00

zachmargolis reviewed Jul 21, 2022

View reviewed changes

tomas-nava approved these changes Jul 21, 2022

View reviewed changes

sheldon-b merged commit e3a24d9 into main Jul 21, 2022

sheldon-b deleted the sbachstein/lg-6872-create-usps-enrollment-in-ipp-flow branch July 21, 2022 16:19

sheldon-b mentioned this pull request Jul 21, 2022

LG-6872: Create USPS barcode using the user's enrollment code #6619

Merged

mitchellhenke mentioned this pull request Jul 26, 2022

Deploy RC 201 to Production #6633

Merged

tomas-nava mentioned this pull request Jul 27, 2022

LG-7241: Handle errors when creating USPS enrollment #6629

Merged

		response = proofer.request_enroll(applicant)
		response['enrollmentCode']

		@@ -59,6 +60,52 @@ def in_person_enrollment?(user)
		# WILLFIX: After LG-6872 and we have enrollment saved, reference enrollment instead.

Conversation

sheldon-b commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Future work

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheldon-b Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomas-nava left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheldon-b Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sheldon-b commented Jul 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sheldon-b commented Jul 21, 2022 •

edited

Loading

sheldon-b Jul 21, 2022 •

edited

Loading

tomas-nava left a comment •

edited

Loading

sheldon-b Jul 22, 2022 •

edited

Loading