Shannon/lg 6089 select location page -Draft pr#6607
Closed
svalexander wants to merge 44 commits intomainfrom
Closed
Shannon/lg 6089 select location page -Draft pr#6607svalexander wants to merge 44 commits intomainfrom
svalexander wants to merge 44 commits intomainfrom
Conversation
- add trouble-shooting options - change submit button to continue - add spacing around <hr> - correct bg color for icon list icons - correct font weight & position on icon list titles
make pages TypeScript
they've moved to the React app
Contributor
|
Overall looks good! A few comments/questions:
Saw a note that the button on mobile is still being worked on so happy to give another visual review when thats ready! Can also test out the functionality if you have this in a sandbox |
Contributor
Author
|
Contributor
|
Looks like we are using 338px in Figma, but if there is a more natural breakpoint around there, that works too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr sets up the in-person-location-step. This step is added to the javascript app and is reached when a user chooses to verify their identity in person at a USPS location after their id verification fails.
This pr adds two components to the javascript components - the LocationCollectionItem and LocationCollection. Both are based off of USWDS components but customized to match the UI design for this step in Figma.
In the location step a fetch is made to a route defined in routes.rb. This endpoint (http://localhost:3000/verify/in_person/usps_locations) hosts json for the locations returned from the controller. In the step the a helper function named formatLocation() formats the address so that city, state and zip code form a single string. The step then displays the locations within the components described above.
It is important to note that the data currently being displayed is not from the USPS api, but rather from a json file in the repo. For the pilot the data that will be displayed will be for the pilot locations.
Things that need to be completed:
Web Screenshots



Mobile Screenshots



