LG-6348: Implement "Ready to verify" page content#6580
Conversation
There was a problem hiding this comment.
Question: Will we want to reformat these keys to match snake_case conventions?
As-is, this matches what we receive from USPS (example).
There was a problem hiding this comment.
Yes, we will most likely be storing the address data in a custom format; that's being worked out in LG-6089 & LG-6872, and I've added notes to those tickets to make sure to update this page when it's established.
b385c44 to
b5875eb
Compare
9aa0e3f to
21a8045
Compare
21a8045 to
2d98a7c
Compare
| def barcode_data_url | ||
| "data:image/png;base64,#{Base64.strict_encode64(barcode_image_data)}" | ||
| end |
There was a problem hiding this comment.
As I'm beginning to work on LG-6343 (email notification) which is also meant to include an image of the barcode, I may plan to revise the output, since data URLs are not well-supported in email clients ([1][2][3]). The Barby gem supports a number of "Outputters", and the HTML outputter seems to be the most promising for email compatibility, and wouldn't be a big lift to swap in to use in the web layout for consistency.
I probably won't change it here now, but will revisit with the pull request for LG-6343.
There was a problem hiding this comment.
(A preview of this rework can be seen at #6585)
|
Thanks for the great feedback @lizzieamanning !
I'll take a look at this. It should automatically be working the way you'd hoped for. One caveat is that it only scrolls to the step if it was scrollable when the page first loaded, and not if you resize the screen down. Just noting in case that's how you'd tested it, but I'll take a closer look regardless.
Yeah, I think so. I'd already implemented localization for some of the USPS labels like "Closed", so I can do something similar for the days of the week. I'll work on that this afternoon.
Ah, sorry, that's on me. I should have clarified there was some missing pieces here due to other dependencies, but I'll elaborate on your specific comments:
|
Following-up, this seems to work as expected for me (screenshot), except for the scenario of reducing screen size after the page is already loaded. @lizzieamanning Could you confirm if you recall seeing this on the initial page load and, if so, what device / browser you were using for testing? |
Improve accessibility See: #6580 (comment)
This was a bit easier than I expected, since this wasn't part of the USPS data and instead fully within our control. I updated it in f308b5f.
Testing it again with the screen reader, the readability is definitely improved, but it doesn't indicate the range as "Monday to Friday" as I might have hoped. Instead, it reads as "Monday Friday", which is certainly better than "Monfry", but not perfect, since I could see this being misinterpreted as "Monday, Friday[, and not any other days of the week]".
I was hopeful that using the correct punctuation (an endash "–" instead of a hyphen "-") would be interpreted by the screen reader, but based on a related resource, it doesn't seem that screen readers have very good support for it. A couple ideas for next steps:
@lizzieamanning Would you have any preference among these options? |
|
f308b5f to
d488d81
Compare
I might be inclined to split out a separate ticket for this, since it'll be blocked by LG-6868 and/or LG-6872 (depending on timing of that work). I'm happy to write that up. One clarifying question around logging in: Since a user could want to go straight to https://secure.login.gov and access their account dashboard, or log in through another service provider at IAL1 (no identity verification required), am I correct in assuming we'd only want to show this page if they're trying to sign in with a service provider which requires a proofed identity?
I also checked to see if we might have some text in the code we could reuse, but it doesn't appear that we do. |
I was just thinking of the need for this ticket, thank you Andrew!
Yes, I believe that's a safe assumption. |
|
@aduth is it ok to google translate "Monday to Friday," ? I recall us mentioning that in stand up since its just days of the week, but let me know if you think we should send it through Gengo and I'll do that |
tomas-nava
left a comment
There was a problem hiding this comment.
approve! Once you wrap up the issues you've noted in comments, I think this is good to go.
@lizzieamanning and I synced on Slack and decided to get professional translations for these day ranges, which is updated as of 4d8c8ee.
This was addressed (see #6580 (comment)).
The new ticket for this is LG-6882. |
**Why**: So that a user has the instructions they need to proof their identity in person. changelog: Upcoming Features, In-Person Proofing, Redirect user to "Ready to verify" page on flow completion
Improve accessibility See: #6580 (comment)
As of LG-6708, now available: selected_location_hours, current_address_matches_id
59b74d6 to
ac07bc6
Compare
Could 500 if user doesn't have a profile




Why: So that a user has the instructions they need to proof their identity in person.
Testing Instructions:
Screenshot: