Rename LexisNexis constant from "lexisnexis" to "lexis_nexis"#6581
Merged
Rename LexisNexis constant from "lexisnexis" to "lexis_nexis"#6581
Conversation
aduth
force-pushed
the
aduth-lg-6348-ready-to-verify
branch
from
b385c44 to
b5875eb
Compare
**Why**: So that we're referencing vendor names consistently. changelog: Internal, Code Quality, Normalize proofing vendor name references
aduth
force-pushed
the
aduth-lexis-nexis-vendor-constant
branch
from
9d4cb2e to
873c11e
Compare
Contributor
Author
|
Returning to this, it occurs to me that since the LexisNexis vendor name is used in configuration, we would need to change that value to match the new constant. But that also means we'd need to support both for a short time. I'm thinking the way we could handle this is temporarily hard-coding both versions in the relevant switch statement: when Idp::Constants::Vendors::LEXIS_NEXIS, 'lexisnexis'(cc for awareness @solipet, since I think you last adjusted these vendor configurations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #6576 (comment)
Why: So that we're referencing vendor names consistently.
Temporarily merges to #6576.
Requires configuration changes which cannot be made for at least the next couple days (see related Slack discussion).