Rename LexisNexis constant from "lexisnexis" to "lexis_nexis"

app/services/doc_auth_router.rb

@@ -168,7 +168,7 @@ def self.client(vendor_discriminator: nil, warn_notifier: nil, analytics: nil)
           glare_threshold: IdentityConfig.store.doc_auth_error_glare_threshold,
         ),
       )
-    when Idp::Constants::Vendors::LEXIS_NEXIS
+    when Idp::Constants::Vendors::LEXIS_NEXIS, 'lexisnexis' # Use constant once configured in prod
       DocAuthErrorTranslatorProxy.new(
         DocAuth::LexisNexis::LexisNexisClient.new(
           account_id: IdentityConfig.store.lexisnexis_account_id,

app/services/idv/steps/verify_base_step.rb

@@ -14,8 +14,8 @@ def summarize_result_and_throttle_failures(summary_result)
 
       def add_proofing_components
         ProofingComponent.create_or_find_by(user: current_user).update(
-          resolution_check: 'lexis_nexis',
-          source_check: 'aamva',
+          resolution_check: Idp::Constants::Vendors::LEXIS_NEXIS,
+          source_check: Idp::Constants::Vendors::AAMVA,
         )
       end
 

lib/idp/constants.rb

@@ -2,9 +2,10 @@ module Idp
   module Constants
     module Vendors
       ACUANT = 'acuant'
-      LEXIS_NEXIS = 'lexisnexis'
+      LEXIS_NEXIS = 'lexis_nexis'
       MOCK = 'mock'
       USPS = 'usps'
+      AAMVA = 'aamva'
     end
 
     DEFAULT_IAL = 1

spec/features/idv/doc_auth/verify_step_spec.rb

@@ -38,8 +38,8 @@
     expect(page).to have_current_path(idv_phone_path)
     expect(page).to have_content(t('doc_auth.forms.doc_success'))
     user = User.first
-    expect(user.proofing_component.resolution_check).to eq('lexis_nexis')
-    expect(user.proofing_component.source_check).to eq('aamva')
+    expect(user.proofing_component.resolution_check).to eq(Idp::Constants::Vendors::LEXIS_NEXIS)
+    expect(user.proofing_component.source_check).to eq(Idp::Constants::Vendors::AAMVA)
     expect(DocAuthLog.find_by(user_id: user.id).aamva).to eq(true)
     expect(fake_analytics).to have_logged_event(
       'IdV: doc auth optional verify_wait submitted',

spec/services/doc_auth_router_spec.rb

@@ -7,7 +7,7 @@
     end
 
     context 'for acuant' do
-      let(:doc_auth_vendor) { 'acuant' }
+      let(:doc_auth_vendor) { Idp::Constants::Vendors::ACUANT }
 
       it 'is a translation-proxied acuant client' do
         expect(DocAuthRouter.client).to be_a(DocAuthRouter::DocAuthErrorTranslatorProxy)
@@ -16,7 +16,7 @@
     end
 
     context 'for lexisnexis' do
-      let(:doc_auth_vendor) { 'lexisnexis' }
+      let(:doc_auth_vendor) { Idp::Constants::Vendors::LEXIS_NEXIS }
 
       it 'is a translation-proxied lexisnexis client' do
         expect(DocAuthRouter.client).to be_a(DocAuthRouter::DocAuthErrorTranslatorProxy)
@@ -130,8 +130,8 @@
       end
 
       it 'client returns randomized vendors when configured' do
-        doc_auth_vendor = 'acuant'
-        doc_auth_vendor_randomize_alternate_vendor = 'lexisnexis'
+        doc_auth_vendor = Idp::Constants::Vendors::ACUANT
+        doc_auth_vendor_randomize_alternate_vendor = Idp::Constants::Vendors::LEXIS_NEXIS
         doc_auth_vendor_randomize_percent = 35
 
         allow(IdentityConfig.store).to receive(:doc_auth_vendor).and_return(doc_auth_vendor)