Skip to content

LG-6348: Redirect user to "Ready to verify" page on completion#6576

Merged
aduth merged 13 commits intomainfrom
aduth-lg-6348-ready-to-verify
Jul 14, 2022
Merged

LG-6348: Redirect user to "Ready to verify" page on completion#6576
aduth merged 13 commits intomainfrom
aduth-lg-6348-ready-to-verify

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 11, 2022

Why: So that a user who chooses to verify their identity in-person can be given instructions on how to complete the process in person.

This is meant to implement a basic scaffolding for the page of LG-6348, with actual page content to be built as follow-on work.

Testing Instructions:

  1. Navigate to http://localhost:3000
  2. Sign in
  3. Navigate to http://localhost:3000/verify
  4. Complete proofing flow up to document capture
  5. Use error document to trigger error result
  6. Click troubleshooting link to proof in person
  7. Complete proofing flow
  8. Observe page shown in screenshot below at end of proofing flow

Screenshot:

image

@aduth aduth marked this pull request as ready for review July 12, 2022 12:36
@aduth aduth requested a review from a team July 12, 2022 12:36
end

def in_person_profile?(user)
ProofingComponent.find_by(user: user)&.document_check == DocAuth::Vendors::USPS
Copy link
Contributor Author

@aduth aduth Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could look for an enrollment for the user and use that as the primary indicator, if we think that's the better canonical source of truth. I expect we'll probably want to be tracking the proofing component regardless though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a local branch from this one to build out the rest of the content for this page, and we'll most certainly need to reference the actual enrollment record associated with this proofing attempt, so I'm thinking it'd probably be best to consider that value here. That being said, we don't actually create an enrollment yet, so maybe we should revisit that once we are.

@tomas-nava Do we have a ticket which captures the creation of the enrollment record?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on using the enrollment. That does seem like a better source of truth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think we should check the enrollment. I don't think there's a ticket yet for creating the enrollment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my read of LG-6708 / #6556, the new "establishing" status looks like it'll be used so we can create the enrollment sometime early on in the flow. I think once we have that, I'll plan to update to reference the enrollment record. I'll leave some "WILLFIX" comments and can hopefully resolve it in one of the further iterations of the work of this ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new ticket LG-6868 will probably tie into this as well, since we'll need to consider the enrollment as part of updating the profile at the password confirmation step.

@aduth aduth force-pushed the aduth-lg-6348-ready-to-verify branch from b385c44 to b5875eb Compare July 13, 2022 14:21
@aduth
Copy link
Contributor Author

aduth commented Jul 14, 2022

Admin merging due to ongoing GitLab issues (see Slack discussion).

@aduth aduth merged commit 6f37480 into main Jul 14, 2022
@aduth aduth deleted the aduth-lg-6348-ready-to-verify branch July 14, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants