Show "Come Back Later" as final screen with GPO + IPP#6596
Merged
Conversation
So it can be easily reused
**Why**: A user who completes the in-person proofing flow while opting to verify their address by receiving a letter (GPO) should be shown the "Come Back Later" screen at the conclusion of the flow, and not be shown instructions directing them to proof in person. changelog: Upcoming Features, In-Person Proofing, Show "Come Back Later" as final screen when opting to verify address by mail
tomas-nava
approved these changes
Jul 18, 2022
Comment on lines
+73
to
+80
| def complete_all_in_person_proofing_steps(user = user_with_2fa) | ||
| complete_location_step(user) | ||
| complete_prepare_step(user) | ||
| complete_state_id_step(user) | ||
| complete_address_step(user) | ||
| complete_ssn_step(user) | ||
| complete_verify_step(user) | ||
| end |
Contributor
There was a problem hiding this comment.
thank you for making these!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: A user who completes the in-person proofing flow while opting to verify their address by receiving a letter (GPO) should be shown the "Come Back Later" screen at the conclusion of the flow, and not be shown instructions directing them to proof in person.
This is a correction to the behavior implemented in #6576. Previously, a user would always be redirected to "Ready to verify", regardless of how they had selected to verify their address.