Do not specify sender_id and origination_number configuration together#6583
Merged
mitchellhenke merged 1 commit intomainfrom Jul 13, 2022
Merged
Conversation
zachmargolis
approved these changes
Jul 13, 2022
lib/telephony/pinpoint/sms_sender.rb
Outdated
Contributor
There was a problem hiding this comment.
another option would be {}.compact which would remove keys with nil values 🤷 again six of one, half a dozen of the other
changelog: Internal, Telephony, Do not specify sender_id and origination_number configuration together
mitchellhenke
force-pushed
the
mitchellhenke/pinpoint-sender-id-part-2
branch
from
6a4b336 to
7bcfb87
Compare
Contributor
Author
|
Force merging due to an issue with GitLab that needs further investigation |
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 13, 2022
#6583) changelog: Internal, Telephony, Do not specify sender_id and origination_number configuration together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6572 because AWS has clarified that we should drop the configuration keys in the API call, rather than setting to
nil