LG-6087 Add prep page to in-person flow#6515
Merged
tomas-nava merged 53 commits intomainfrom Jul 14, 2022
Merged
Conversation
added 11 commits
June 23, 2022 10:28
- add trouble-shooting options - change submit button to continue - add spacing around <hr> - correct bg color for icon list icons - correct font weight & position on icon list titles
aduth
reviewed
Jun 23, 2022
app/javascript/packages/components/icon-list/icon-list-item.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-prepare-step.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-prepare-step.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/components/process-list/process-list-heading.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/document-capture.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-location-step.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/components/process-list/process-list-heading.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-prepare-step.jsx
Outdated
Show resolved
Hide resolved
- no forwarded ref - remove extends
make pages TypeScript
they've moved to the React app
…erify-your-identity-page
…erify-your-identity-page
aduth
reviewed
Jun 29, 2022
app/javascript/packages/document-capture/components/in-person-location-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-prepare-step.tsx
Outdated
Show resolved
Hide resolved
added 3 commits
June 29, 2022 12:58
added 9 commits
July 10, 2022 11:41
…erify-your-identity-page
changelog: Upcoming Features, In-Person Proofing, Add the 'Verify your identity in person' page to the IPP flow (LG-6087)
aduth
approved these changes
Jul 11, 2022
app/javascript/packages/components/icon-list/icon-list-content.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-prepare-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/document-capture.jsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/review-issues-step.tsx
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/in-person-troubleshooting-options.tsx
Show resolved
Hide resolved
Contributor
|
I was hoping that restarting the GitLab job would clear up the failure, but no such luck. You may need to rebase / merge main to get the changes from #6571, which should hopefully resolve it. |
added 2 commits
July 11, 2022 15:21
one can tab to this link when the browser is configured correctly
sheldon-b
approved these changes
Jul 13, 2022
Contributor
sheldon-b
left a comment
sheldon-b
left a comment
There was a problem hiding this comment.
How are we handling the step indicator on these React pages? It's different from the designs
Otherwise this looks good to me, nice work
added 5 commits
July 12, 2022 22:15
add tests for ones that do
a more precise description of its purpose
…erify-your-identity-page
Contributor
Author
It is different, but it's more work than I'm ready to take on in this ticket, so I'm deferring it to LG-6308 |
aduth
reviewed
Jul 13, 2022
added 5 commits
July 13, 2022 08:10
…erify-your-identity-page
…erify-your-identity-page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new "Verify your identity in person" page to the in-person proofing flow. Specifically add as a page to the DocAuth React app so that the user can return to the image upload step without losing information.
screenshots:
Desktop
Mobile
notes:
This is a work in progress; still left to do:
Account for the new pages in the FormSteps componentOnly add IPP steps to the flow if the feature flag's enabledThe display of the submit button in troubleshooting options isn't perfectContinue to the non-React IPP flow from this new pageRemove location & prep steps from in person flow (now that they've been replaced with react pages)Add & update testsAdd placement French & Spanish translations