Skip to content

Drop users.encrypted_phone column #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 2 commits into from
Jul 5, 2022
Merged

Drop users.encrypted_phone column #6549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b2ab5
Drop users.encrypted_phone column
zachmargolis Jul 5, 2022
cee064c
Drop users.totp_timestamp
zachmargolis Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class User < ApplicationRecord
self.ignored_columns = %w[encrypted_phone totp_timestamp]
self.ignored_columns = %w[totp_timestamp]

@mitchellhenke mitchellhenke Jul 5, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also drop this 😬

@zachmargolis zachmargolis Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean drop the totp_timestamp column?

@zachmargolis zachmargolis Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I guess it's already ignored, so may as well drop it 🤷

@zachmargolis zachmargolis Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: cee064c

@mitchellhenke mitchellhenke Jul 5, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's been ignored for...2.5 years so I think we're good 😀

include NonNullUuid

include ::NewRelic::Agent::MethodTracer
Expand Down
5 changes: 5 additions & 0 deletions db/primary_migrate/20220705195340_drop_encrypted_phone_from_users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class DropEncryptedPhoneFromUsers < ActiveRecord::Migration[6.1]
def change
safety_assured { remove_column :users, :encrypted_phone, :string }
end
end
3 changes: 1 addition & 2 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 2022_06_22_232047) do
ActiveRecord::Schema.define(version: 2022_07_05_195340) do

# These are extensions that must be enabled in order to support this database
enable_extension "pg_stat_statements"
Expand Down Expand Up @@ -591,7 +591,6 @@
t.string "direct_otp"
t.datetime "direct_otp_sent_at"
t.string "unique_session_id"
t.text "encrypted_phone"
t.integer "otp_delivery_preference", default: 0, null: false
t.integer "totp_timestamp"
t.string "encrypted_password_digest", default: ""
Expand Down