Update status page layout margins to correct value#6544
Merged
Conversation
zachmargolis
approved these changes
Jul 1, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, looks like missing a changelog line
Per feedback in Figma designs
So we have a single place to update things like margins
changelog: Bug Fixes, Layout, Fix layout spacing for status page
aduth
force-pushed
the
aduth-status-page-margin
branch
from
7a3141b to
ba87897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #6542
Why: Based on Figma designs, there should be 2.5rem of top margin above status page action buttons not 2rem.
Refactors
ForgotPasswordcomponent to useStatusPagecomponent to consolidate layout updates for these screens.