Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/drop-unused-user-columns-4
branch
from
f4ce862 to
b507a2e
Compare
zachmargolis
approved these changes
Jun 15, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! drop drop drop!
db/schema.rb
Outdated
Contributor
There was a problem hiding this comment.
👀 oooo definitely not for this PR but I suspect this is another column we could drop because we moved to phone_configurations
Contributor
Author
There was a problem hiding this comment.
Definitely. Likewise I think totp_timestamp could be dropped
mitchellhenke
force-pushed
the
mitchellhenke/drop-unused-user-columns-4
branch
3 times, most recently
from
72c2601 to
2327a4a
Compare
changelog: Internal, Database, Drop users email columns
mitchellhenke
force-pushed
the
mitchellhenke/drop-unused-user-columns-4
branch
from
2327a4a to
96d0d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not be merged until #6474 and #6480 are deployed everywhere