Conversation
This commit adds the ability to ban users using a db table: - A service provider column can be used for a SP specific ban - If no SP is specified, the user is banned for all SP Using a database table was chosen over a config value to allow users to be quickly banned without need to recycle to re-apply configs.
db/primary_migrate/20220129181752_create_sign_in_restrictions.rb
Outdated
Show resolved
Hide resolved
mitchellhenke
approved these changes
Jan 29, 2022
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Couple non-blocking questions, looks good 👍🏼
jmhooper
added a commit
that referenced
this pull request
Jan 29, 2022
* Add the ability to ban users This commit adds the ability to ban users using a db table: - A service provider column can be used for a SP specific ban - If no SP is specified, the user is banned for all SP Using a database table was chosen over a config value to allow users to be quickly banned without need to recycle to re-apply configs.
| create_table :sign_in_restrictions do |t| | ||
| t.integer :user_id, null: false | ||
| t.string :service_provider | ||
|
|
Contributor
There was a problem hiding this comment.
maybe for the future we can add a followup for with a reason (internal only, just for record keeping)
Suggested change
| t.string :reason | |
aduth
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Add the ability to ban users This commit adds the ability to ban users using a db table: - A service provider column can be used for a SP specific ban - If no SP is specified, the user is banned for all SP Using a database table was chosen over a config value to allow users to be quickly banned without need to recycle to re-apply configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to ban users using a db table:
Using a database table was chosen over a config value to allow users to be quickly banned without need to recycle to re-apply configs.