changelog: Improvements, pull in ad-hoc styling from idp, LG-5883#309
Merged
SammySteiner merged 3 commits intomainfrom Mar 31, 2022
Merged
changelog: Improvements, pull in ad-hoc styling from idp, LG-5883#309SammySteiner merged 3 commits intomainfrom
SammySteiner merged 3 commits intomainfrom
Conversation
aduth
reviewed
Mar 29, 2022
CHANGELOG.md
Outdated
| - Reconcile redundant focus styles with U.S. Web Design System. ([#302](https://github.com/18F/identity-style-guide/pull/302)) | ||
| - Remove documentation site styles from design system artifact. ([#305](https://github.com/18F/identity-style-guide/pull/305)) | ||
| - Reduce size of SVG images. ([#307](https://github.com/18F/identity-style-guide/pull/307)) | ||
| - Incorporate mfa icon styles, which were previously added to the identity-idp. ([#309](https://github.com/18F/identity-style-guide/pull/309)) |
Contributor
There was a problem hiding this comment.
This might fit better under an "Improvements" or "Bug Fixes" section, since it's not really a performance optimization. Could we describe what the change is. IIRC it's improving/increasing the spacing around the icon?
Contributor
|
Visual regression build failure seems to be expected, based on changes to the tile fields. Via artifacts:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.