Merged
Conversation
aduth
reviewed
Feb 14, 2022
Contributor
Author
|
Hiya @aduth I appreciate the work that's been done with ButtonComponent. I have a few suggestions for improvement:
|
Contributor
Yeah, based on how common it is to use a button as a link, I think a Related: #5910 (comment) |
aduth
reviewed
Feb 17, 2022
0ab8976 to
8210d63
Compare
… use design system (LG-5629)
…se design system (LG-5629)
d891124 to
c811e8d
Compare
aduth
reviewed
Feb 17, 2022
Contributor
aduth
left a comment
There was a problem hiding this comment.
I think we should be able to remove all the account-action-button styles now as well, since we're removing the last of them.
identity-idp/app/assets/stylesheets/components/_btn.scss
Lines 1 to 23 in d024e91
aduth
reviewed
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.