Skip to content

Show any invalid entries in changelog#6031

Merged
mitchellhenke merged 7 commits intomainfrom
mitchellhenke/also-show-invalid-changelog-entries
Mar 23, 2022
Merged

Show any invalid entries in changelog#6031
mitchellhenke merged 7 commits intomainfrom
mitchellhenke/also-show-invalid-changelog-entries

Conversation

@mitchellhenke
Copy link
Contributor

Puzzlingly, GitHub did not include all of the commit messages in the merge commit for #5945 (174f3b3)

All of the other PRs include full commit messages in the squashed merge commit. As an example, the merge commit for #5992 includes commit messages from the PR:

Fix SAML remote logout (#5992)

Correctly invalidate session for SAML Remote Logout (https://github.com/18F/identity-idp/pull/5990)

**Why:** the way this currently worked led to the user's session being
cleared on subsequent visits, which meant that any authentication
request information was lost. This correctly deletes the session from
the Redis cache. It also refactors out an OutOfBandSessionAccessor
service object for this purpose and adds a feature spec for remote logout.

changelog: Bug Fixes, Authentication, Fix issue with SAML remote logout causing subsequent authentication requests not to redirect correctly

* Actually fix SAML remote logout

**Why:** The recent updates were not actually working - we were using
the incorrect session key to invalidate the session in redis. This
update stores the session ID on the SP identity record during SAML
authentication (similar to OIDC) so that it can be retrieved during
remote logout. This is actually a safer behavior since it means that a
user will only be logged out if the session they logged in with is still
valid (whereas before they would have been logged out regardless if they
had started a new Login.gov session after authenticating to the SP).

Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>

This PR adds a second pass to find those unskipped, yet invalid commits and appends them to the end so that they can still at least be captured in release notes.

Ex:

./scripts/changelog-check -b 2022-02-25T195852 -s origin/stages/rc-2022-03-03-patch1
## Improvements
- OpenID Connect: Add sig and alg keys to OIDC certificates endpoint ([#6007](https://github.com/18F/identity-idp/pull/6007))
- Optimization: Reduce size of JavaScript bundles ([#6002](https://github.com/18F/identity-idp/pull/6002))
- Optimization: Reduce size of base layout assets ([#5967](https://github.com/18F/identity-idp/pull/5967))
- Layout: Use design system for layout ([#5953](https://github.com/18F/identity-idp/pull/5953), [#5986](https://github.com/18F/identity-idp/pull/5986))
- Typography: Use design system for typography utilities ([#5972](https://github.com/18F/identity-idp/pull/5972))

## Bug Fixes
- Authentication: Switch remember device cookie to session expiration ([#6024](https://github.com/18F/identity-idp/pull/6024))
- Logging: Clarify logging for proofing timeouts ([#6013](https://github.com/18F/identity-idp/pull/6013))
- Account Recovery: Add flow to help accounts replace personal keys ([#6010](https://github.com/18F/identity-idp/pull/6010))
- Password Entry: Add missing messages for password strength feedback ([#6008](https://github.com/18F/identity-idp/pull/6008))
- Email Confirmation: Fix 500 error during email address confirmation ([#6005](https://github.com/18F/identity-idp/pull/6005))
- Authentication: Fix issue with SAML remote logout causing subsequent authentication requests not to redirect correctly ([#5990](https://github.com/18F/identity-idp/pull/5990), [#5992](https://github.com/18F/identity-idp/pull/5992))
- Account Deletion: Fix 500 error while deleting account ([#6000](https://github.com/18F/identity-idp/pull/6000))
- Layout: Fix logo display in Internet Explorer ([#5993](https://github.com/18F/identity-idp/pull/5993))
- Account Management: Fix error on attempting deletion of invalid webauthn configuration ([#5999](https://github.com/18F/identity-idp/pull/5999))
- Authentication: Fix 500 error when sending phone OTP ([#5987](https://github.com/18F/identity-idp/pull/5987))
- OpenID Connect: Updates "street_address" claim formatting ([#5985](https://github.com/18F/identity-idp/pull/5985))

## Internal
- Dependencies: Dependencies were updated to the latest version ([#6026](https://github.com/18F/identity-idp/pull/6026))
- Linting: Improve default configuration for TypeScript linting compatibility ([#6016](https://github.com/18F/identity-idp/pull/6016))
- Build: Include dynamic JavaScript files for translation string extraction ([#6015](https://github.com/18F/identity-idp/pull/6015))
- Localization: Improve localization accuracy for JavaScript strings ([#6009](https://github.com/18F/identity-idp/pull/6009))
- Developer Experience: Add component preview routes for local development ([#5982](https://github.com/18F/identity-idp/pull/5982))
- Code Quality: Standardize JavaScript translation implementation ([#6001](https://github.com/18F/identity-idp/pull/6001))
- Identity Verification: Validate zip code field ([#5997](https://github.com/18F/identity-idp/pull/5997))
- Dependencies: Update design system to latest version ([#5988](https://github.com/18F/identity-idp/pull/5988))
- Optimization: Remove duplicate page styles ([#5979](https://github.com/18F/identity-idp/pull/5979), [#5980](https://github.com/18F/identity-idp/pull/5980))
- Dependencies: Remove unused dependencies ([#5983](https://github.com/18F/identity-idp/pull/5983))

!!! Invalid Changelog Entries !!!
LG-5629 account buttons part 2 (#5945)

@mitchellhenke mitchellhenke marked this pull request as ready for review March 3, 2022 23:17
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As this script gets bigger I think it would be nice to have tests!

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/also-show-invalid-changelog-entries branch 3 times, most recently from 69c20e2 to 2770bd0 Compare March 9, 2022 21:56
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/also-show-invalid-changelog-entries branch 4 times, most recently from 0fb6f63 to d2140a6 Compare March 16, 2022 14:09
Mitchell Henke added 4 commits March 23, 2022 08:10
changelog: Internal, Changelog Management, Always print changelog and show any invalid entries
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/also-show-invalid-changelog-entries branch 2 times, most recently from 121e6ba to 22cea89 Compare March 23, 2022 13:43
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/also-show-invalid-changelog-entries branch from 22cea89 to 13e5a8c Compare March 23, 2022 13:45
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Comment on lines 112 to +115
category: category,
subcategory: change[:subcategory].capitalize,
pr_number: pr_number&.named_captures&.fetch('pr'),
change: change[:change].capitalize,
change: change[:change].sub(/./, &:upcase),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a fixture case for the uppercase formatting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a spec in 806ba4b

@mitchellhenke mitchellhenke merged commit dfb51d8 into main Mar 23, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/also-show-invalid-changelog-entries branch March 23, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants