Show any invalid entries in changelog#6031
Merged
mitchellhenke merged 7 commits intomainfrom Mar 23, 2022
Merged
Conversation
zachmargolis
approved these changes
Mar 3, 2022
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM
As this script gets bigger I think it would be nice to have tests!
69c20e2 to
2770bd0
Compare
zachmargolis
reviewed
Mar 9, 2022
zachmargolis
reviewed
Mar 9, 2022
0fb6f63 to
d2140a6
Compare
added 4 commits
March 23, 2022 08:10
changelog: Internal, Changelog Management, Always print changelog and show any invalid entries
121e6ba to
22cea89
Compare
22cea89 to
13e5a8c
Compare
aduth
reviewed
Mar 23, 2022
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
reviewed
Mar 23, 2022
Comment on lines
112
to
+115
| category: category, | ||
| subcategory: change[:subcategory].capitalize, | ||
| pr_number: pr_number&.named_captures&.fetch('pr'), | ||
| change: change[:change].capitalize, | ||
| change: change[:change].sub(/./, &:upcase), |
Contributor
There was a problem hiding this comment.
Could we add a fixture case for the uppercase formatting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puzzlingly, GitHub did not include all of the commit messages in the merge commit for #5945 (174f3b3)
All of the other PRs include full commit messages in the squashed merge commit. As an example, the merge commit for #5992 includes commit messages from the PR:
This PR adds a second pass to find those unskipped, yet invalid commits and appends them to the end so that they can still at least be captured in release notes.
Ex: