Increase rack timeout in test environment too#5766
Closed
zachmargolis wants to merge 1 commit intomainfrom
Closed
Conversation
Contributor
zachmargolis
commented
Dec 30, 2021
zachmargolis
commented
- Follow-up to Increase rack timeout in development to fix assets locally #5765
- Follow-up to #5765
| phone_setups_per_ip_track_only_mode: 'false' | ||
| piv_cac_verify_token_secret: 3ac13bfa23e22adae321194c083e783faf89469f6f85dcc0802b27475c94b5c3891b5657bd87d0c1ad65de459166440512f2311018db90d57b15d8ab6660748f | ||
| poll_rate_for_verify_in_seconds: '1' | ||
| rack_timeout_service_timeout_seconds: 9_999_999_999 |
Contributor
There was a problem hiding this comment.
I'm less sure about doing this in test, I'd rather not have a test wait 300 years to fail 😛
Contributor
Author
There was a problem hiding this comment.
😬 so what should we set it to?
Contributor
There was a problem hiding this comment.
If we haven't seen any issues in test, leaving the default seems fine for now?
Contributor
Author
There was a problem hiding this comment.
I thought I was getting segfaults in test but I guess not! Will close this for now and we can always redo if others have issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.