Skip to content

Increase rack timeout in test environment too #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zachmargolis wants to merge 1 commit into from
Closed

Increase rack timeout in test environment too #5766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ test:
phone_setups_per_ip_track_only_mode: 'false'
piv_cac_verify_token_secret: 3ac13bfa23e22adae321194c083e783faf89469f6f85dcc0802b27475c94b5c3891b5657bd87d0c1ad65de459166440512f2311018db90d57b15d8ab6660748f
poll_rate_for_verify_in_seconds: '1'
rack_timeout_service_timeout_seconds: 9_999_999_999
Copy link
Copy Markdown
Contributor

@mitchellhenke mitchellhenke Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less sure about doing this in test, I'd rather not have a test wait 300 years to fail 😛

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 so what should we set it to?

Copy link
Copy Markdown
Contributor

@mitchellhenke mitchellhenke Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we haven't seen any issues in test, leaving the default seems fine for now?

Copy link
Copy Markdown
Contributor Author

@zachmargolis zachmargolis Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was getting segfaults in test but I guess not! Will close this for now and we can always redo if others have issues

recurring_jobs_disabled_names: '["disabled job"]'
reg_confirmed_email_max_attempts: '3'
reg_unconfirmed_email_max_attempts: '4'
Expand Down