Skip to content

Increase rack timeout in development to fix assets locally #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Dec 30, 2021
Merged

Increase rack timeout in development to fix assets locally #5765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ development:
password_pepper: f22d4b2cafac9066fe2f4416f5b7a32c
piv_cac_verify_token_secret: ee7f20f44cdc2ba0c6830f70470d1d1d059e1279cdb58134db92b35947b1528ef5525ece5910cf4f2321ab989a618feea12ef95711dbc62b9601e8520a34ee12
rails_mailer_previews_enabled: 'true'
rack_timeout_service_timeout_seconds: 9_999_999_999
Copy link
Contributor

@jmhooper jmhooper Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want a string here. Also, we can probably make is something more reasonable, like 10 minutes

Copy link
Contributor Author

@zachmargolis zachmargolis Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's valid YAML! and our config parser just calls Integer() on it anyways

require 'yaml'
YAML.load <<-STR
rack_timeout_service_timeout_seconds: 9_999_999_999
STR
=> {"rack_timeout_service_timeout_seconds"=>9999999999}

identity-idp/lib/identity_config.rb

Lines 18 to 20 in 0f018a5

integer: proc do |value|
Integer(value)
end,

Copy link
Contributor

@jmhooper jmhooper Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sweet. There used to be something that yelled at you when you put non string values in here. Maybe that went away with Figaro.

Copy link
Contributor

@mitchellhenke mitchellhenke Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a Figaro-ism because it also had to be able to write the value to the system environment variable

Copy link
Contributor

@solipet solipet Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add this to test as well?

Copy link
Contributor Author

@zachmargolis zachmargolis Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure the problem happened most often in development? But yeah I guess it wouldn't hurt to add to test... will follow up

Copy link
Contributor Author

@zachmargolis zachmargolis Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5766

recurring_jobs_disabled_names: "[]"
s3_report_bucket_prefix: ''
s3_report_public_bucket_prefix: ''
Expand Down