LG-4637: Show accurate time remaining for IAL2 throttle screens#5301
LG-4637: Show accurate time remaining for IAL2 throttle screens#5301
Conversation
aduth
force-pushed
the
aduth-lg-4637-throttle-time
branch
from
296cf9e to
bd57718
Compare
|
There's another instance of this message I still need to deal with for phone failure: identity-idp/app/views/idv/phone_errors/failure.html.erb Lines 24 to 26 in 439d270 This looks a bit complicated to address, because of how there seems to be a separate throttling mechanism using the IDV session (example). I'm not sure if there was a compelling reason to do it this way, or if we could migrate these to using the standard throttling behaviors. |
aduth
force-pushed
the
aduth-lg-4637-throttle-time
branch
from
d7fd2b0 to
561fe01
Compare
aduth
force-pushed
the
aduth-lg-4637-throttle-time
branch
from
6a14a0e to
72c28ea
Compare
… type **Why**: So that each throttle error screen corresponds to exactly one throttle type, to accommodate accurate time labels proposed in #5301 (LG-4637).
There was a problem hiding this comment.
throttled is for the :idv_acuant throttle type, so this isn't quite correct. Will fix in revisions accounting for separate SSN throttle via #5346. I'll also double-check to see why feature tests didn't flag this.
There was a problem hiding this comment.
I'll also double-check to see why feature tests didn't flag this.
There were feature specs for this, but they weren't specifically checking the content as showing an expected time remaining. I've added an extra set of assertions in the rebased 1612180 (see document_capture_step_spec.rb).
**Why**: As a user, I expect that if I encounter an error screen informing me that I am unable to proceed due to too many attempts, the text on the page will let me know when I can try again, so that I know when to return to try again, and so that I'm not waiting longer than necessary if I can try again sooner than the text would otherwise imply.
aduth
force-pushed
the
aduth-lg-4637-throttle-time
branch
from
72c28ea to
1612180
Compare
| def ssn_from_doc | ||
| user_session&.dig('idv/doc_auth', 'pii_from_doc', 'ssn') |
There was a problem hiding this comment.
A bit more involved to get at the throttle target value for SSN throttling, vs. others just getting by the current user.
**Why**: Fix flakiness with messaging changing by time elapsed
**Why**: Because we've already frozen time for the duration of the tests, it's not necessary. Also, it raises errors.
* LG-4637: Show accurate time remaining for IAL2 throttle screens **Why**: As a user, I expect that if I encounter an error screen informing me that I am unable to proceed due to too many attempts, the text on the page will let me know when I can try again, so that I know when to return to try again, and so that I'm not waiting longer than necessary if I can try again sooner than the text would otherwise imply. * Freeze time for phone throttling specs **Why**: Fix flakiness with messaging changing by time elapsed * De-block phone throttling time travel **Why**: Because we've already frozen time for the duration of the tests, it's not necessary. Also, it raises errors. (cherry picked from commit e5b0da6)
2 participants
Why: As a user, I expect that if I encounter an error screen informing me that I am unable to proceed due to too many attempts, the text on the page will let me know when I can try again, so that I know when to return to try again, and so that I'm not waiting longer than necessary if I can try again sooner than the text would otherwise imply.
Screenshot: