Replace Timecop with ActiveSupport::Testing::TimeHelpers#5320
Merged
mitchellhenke merged 3 commits intomainfrom Aug 24, 2021
Merged
Replace Timecop with ActiveSupport::Testing::TimeHelpers#5320mitchellhenke merged 3 commits intomainfrom
mitchellhenke merged 3 commits intomainfrom
Conversation
aduth
reviewed
Aug 23, 2021
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/timecop
branch
3 times, most recently
from
f30fe7d to
1f8d638
Compare
mitchellhenke
force-pushed
the
mitchellhenke/timecop
branch
from
1f8d638 to
86a8f8a
Compare
mitchellhenke
commented
Aug 23, 2021
| ) | ||
|
|
||
| Timecop.travel(Time.zone.now + idv_send_link_attempt_window_in_minutes.minutes) do | ||
| travel_to(Time.zone.now + idv_send_link_attempt_window_in_minutes.minutes + 1) do |
Contributor
Author
There was a problem hiding this comment.
Specs like these where time travel is going to the beginning of a window would intermittently fail because it hadn't traveled far enough in time.
I'm not sure if it's due to partial seconds, a delay in Timecop, or something else, but the tests reliably pass by adding a second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Timecop with ActiveSupport's very similar
TimeHelpers. There were also some issues with Timecop in #5301.This PR also removes time travel travel from some specs where it seemed unnecessary.