Skip to content

Set two_words_connector at locale string data#5312

Merged
aduth merged 1 commit intomainfrom
aduth-dotiw-spaces
Aug 19, 2021
Merged

Set two_words_connector at locale string data#5312
aduth merged 1 commit intomainfrom
aduth-dotiw-spaces

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented Aug 19, 2021

Extracted from #5301 (context)

Why: Makes distance_of_time_in_words less error-prone and verbose, and aligns to library documented defaults. It had previously been implemented this way largely due to limitations of YAML normalization resolved by #5066.

**Why**: Makes distance_of_time_in_words less error-prone and verbose, and aligns to library documented defaults. Previously only limited this way due to limitations of YAML normalization resolved by #5066.
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 3f2baec into main Aug 19, 2021
@aduth aduth deleted the aduth-dotiw-spaces branch August 19, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants