Skip to content

Fix smoke tests again#5085

Merged
zachmargolis merged 1 commit intomainfrom
margolis-more-smoke-test-fixes
May 22, 2021
Merged

Fix smoke tests again#5085
zachmargolis merged 1 commit intomainfrom
margolis-more-smoke-test-fixes

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

Why: Smoke tests run outside of rails,
so path helpers are not available


This time, from #5040

(Deja vu? Last one was #5084 for #4968)

Error

  5) smoke test: SP initiated sign in OIDC redirects back to SP
     Failure/Error: if current_path == rules_of_use_path
     
     NameError:
       undefined local variable or method `rules_of_use_path' for #<RSpec::ExampleGroups::SmokeTestSPInitiatedSignIn::OIDC:0x000056038d95ada8>
     # ./spec/support/monitor/monitor_idp_steps.rb:61:in `sign_in_and_2fa'

**Why**: Smoke tests run outside of rails,
so path helpers are not available
@zachmargolis zachmargolis merged commit e4a5a82 into main May 22, 2021
@zachmargolis zachmargolis deleted the margolis-more-smoke-test-fixes branch May 22, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants