Skip to content

Fix smoke tests#5084

Merged
stevegsa merged 1 commit intomainfrom
margolis-fix-smoke-tests-missing-i18n
May 22, 2021
Merged

Fix smoke tests#5084
stevegsa merged 1 commit intomainfrom
margolis-fix-smoke-tests-missing-i18n

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis commented May 22, 2021 •
edited
Loading

Why: Smoke tests run outside of Rails, so I18n
is not available

Small problem with #4968

Error

  1) smoke test: sign in and out creates account, signs out, signs back in
     Failure/Error: check t('sign_up.terms')
     
     NoMethodError:
       undefined method `t' for #<RSpec::ExampleGroups::SmokeTestSignInAndOut:0x0000558ab874b3d0>
     # ./spec/support/monitor/monitor_idp_steps.rb:27:in `create_new_account_up_until_password'

@zachmargolis
Fix smoke tests
aad7764 
**Why**: Smoke tests run outside of Rails, so I18n
is not available
@zachmargolis zachmargolis force-pushed the margolis-fix-smoke-tests-missing-i18n branch from b829c8f to aad7764 Compare May 22, 2021 01:57
@stevegsa stevegsa merged commit 2e13a3c into main May 22, 2021
@stevegsa stevegsa deleted the margolis-fix-smoke-tests-missing-i18n branch May 22, 2021 02:19
@zachmargolis zachmargolis mentioned this pull request May 22, 2021
Merged
@zachmargolis zachmargolis mentioned this pull request Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmhooper jmhooper Awaiting requested review from jmhooper

@mitchellhenke mitchellhenke Awaiting requested review from mitchellhenke

1 more reviewer

@stevegsa stevegsa stevegsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zachmargolis @stevegsa