LG-4449 Implement rules of use for existing users#5040
Merged
Conversation
stevegsa
force-pushed
the
stevegsa-rules-of-use-for-existing-users
branch
from
f8d3539 to
cc4934c
Compare
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
zachmargolis
reviewed
May 7, 2021
stevegsa
added
status - ready for review
status - do not merge
and removed
status - work in progress
labels
aduth
reviewed
May 10, 2021
aduth
approved these changes
May 11, 2021
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
A suggestion at #5040 (comment) that I think is worth including, but otherwise LGTM 👍
aduth
reviewed
May 13, 2021
Contributor
|
FYI #5066 changed how locale YAML files are normalized, so you might want to rebase / merge to check for any local changes. # git fetch origin
# git rebase origin/main
yarn install
make normalize_yaml |
stevegsa
force-pushed
the
stevegsa-rules-of-use-for-existing-users
branch
from
78719bf to
0f02fec
Compare
stevegsa
force-pushed
the
stevegsa-rules-of-use-for-existing-users
branch
from
a6a27b2 to
3b482f1
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.