Skip to content

Stop referencing ServiceProvider#fingerprint #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 1 commit into from
Apr 6, 2021
Merged

Stop referencing ServiceProvider#fingerprint #4884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/null_service_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class NullServiceProvider
default_aal
description
failure_to_proof_url
fingerprint
help_text
iaa
iaa_end_date
Expand Down
1 change: 0 additions & 1 deletion config/service_providers.localdev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ development:
block_encryption: 'aes256-cbc'
sp_initiated_login_url: 'http://localhost:3000/test/saml'
cert: 'saml_test_sp'
fingerprint: '08:79:F5:B1:B8:CC:EC:8F:5C:2A:58:03:30:14:C9:E6:F1:67:78:F1:97:E8:3A:88:EB:8E:70:92:25:D2:2F:32'
logo: 'generic.svg'
agency: 'GSA'
friendly_name: 'Awesome test SP'
Expand Down
6 changes: 0 additions & 6 deletions spec/models/null_service_provider_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@
end
end

describe '#fingerprint' do
it 'returns nil' do
expect(subject.fingerprint).to be_nil
end
end

describe '#logo' do
it 'returns nil' do
expect(subject.logo).to be_nil
Expand Down