Certificate cleanup

[zachmargolis]

I was starting to make changes to the dashboard to support multiple to correspond to 18F/identity-idp#4851

But then I noticed a lot of things I wanted to clean up so I started on that:

1. Removed _certificate_expiration.html.erb partial
   • Inline styles are blocked by our CSP
   • Moved CSS logic on to ServiceProviderCertificate class
2. Updated ServiceProviderCertificate class, it now wraps an X509 cert rather than subclasses one (easier to test)
3. Visual changes: updated the SP "show" page:
   • Full cert body is now hidden behind a details toggle
     • I updated USWDS to fix an error with Chrome and the triangle disclosure being hidden (reverted that fix based on Certificate cleanup #404 (comment))
   • Added some more summary details (I expect these will make it easier to tell multiple certificates apart)

state	before	after
initial
expanded	N/A

[aduth]

This won't be quite so easy an upgrade, unfortunately. Some of the breaking changes do affect the dashboard.

Notably:

Several button variants have been removed. These include: [...]

There's one instance of a dropdown:

identity-dashboard/app/views/manage_users/_add_user_options_dropdown.html.erb

Line 2 in 4b0d991

<button type="button" class="usa-button usa-button--dropdown">

... though last I checked, I'm not sure this partial is even referenced anywhere.

And a tiny button:

identity-dashboard/app/views/teams/_teams_list.html.erb

Line 21 in 4b0d991

<%= link_to service_provider.friendly_name, service_provider, class: "usa-button usa-button--inverse usa-button--tiny margin-top-1" %>

2.x to 3.x is the major upgrade of USWDS: https://github.com/18F/identity-style-guide/blob/main/CHANGELOG.md#300 . This usually includes updating banner markup.

The original ticket for this is LG-3762.

[zachmargolis]

Ok so then I'll revert that maybe I'll just do a quick !important or something one-off style to get the <details>/<summary> fix in?

[aduth]

It might not be that bad if we could remove the dropdown and check or substitute the teams list "tiny" button, but yeah, a one-off fix would be a reasonable alternative if we don't want to deal with it here.

[zachmargolis]

Went with the patch approach in 5c6741f

[aduth]

It existed previously, though the name on the new <details> had caught my attention: Does the for attribute actually do anything for us? This doesn't seem like an appropriate use of a label, since it's not associated with an input.

https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Form_labelable

I could maybe see it as a case for aria-labelledby or aria-describedby.

[zachmargolis]

Looks like they came from #366 from AxE matchers

[zachmargolis]

Ok no that was not right... looks like those have just been there a long time.... it's probably time for them to go, especially since this page isn't a form?

[orenyk]

I wonder if they were copied over from the edit form?

[orenyk]

Looks good!

[zachmargolis]

(overriding snyk because it's stalled out)