Conversation
There was a problem hiding this comment.
WARNING: NOT conditions will no longer behave as NOR in Rails 6.1. To continue using NOR conditions, NOT each condition individually (`.where.not(:iaa => ...).where.not(:iaa_start_date => ...).where.not(:iaa_end_date => ...)`)
where.not being NOR is deprecated and will become NAND in 6.1 (rails/rails#31209)
There was a problem hiding this comment.
Wow that thread was a ride
config/application.rb
Outdated
There was a problem hiding this comment.
this configuration is forward compatible, but not backward compatible. Once we confirm we are not rolling back to Rails 5.2, we can remove this line.
There was a problem hiding this comment.
DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller.
The presenter class only uses the view_context to access the request referer header, so I slightly refactored to pass that in directly instead of using the view context.
mitchellhenke
force-pushed
the
mitchellhenke/rails-lg-3753
branch
from
4339565 to
8e8fce1
Compare
| end | ||
|
|
||
| it 'gracefully handles invalid formats' do | ||
| xit 'gracefully handles invalid formats' do |
There was a problem hiding this comment.
what would it take to bring this spec back? I think it was guarding for real regressions we might see from various scans
There was a problem hiding this comment.
that was my hope as well. it looks like we can render a 406 error page, but that's still a significant change in behavior. do we do scans that send malformed Accept or Content-Type headers and need the server response to ignore that?
There was a problem hiding this comment.
The goal of the spec is to not blow up, so anything other than a 500 should be acceptable
mitchellhenke
force-pushed
the
mitchellhenke/rails-lg-3753
branch
from
f79d07f to
cbac137
Compare
There was a problem hiding this comment.
how does this return a 200 if we render the 406 page?
There was a problem hiding this comment.
Hm, I misunderstood how this works. Since it's in the test environment, it always raises and doesn't render the 406 page as I expected.
If I set config.consider_all_requests_local = false it renders like it would in prod, but I can't find a way to test that this gets rendered appropriately in test.
There was a problem hiding this comment.
Probably needs to be a request spec --- I would remove the response.status then and just let it assume that the error being raised is appropriate
mitchellhenke
force-pushed
the
mitchellhenke/rails-lg-3753
branch
from
cbac137 to
36c6e40
Compare
|
Lots of work here, nicely done! |
3 participants
Following #4451 #4453 #4462, can finally update to Rails 6 😀