Merged
Conversation
added 8 commits
November 23, 2020 14:44
zachmargolis
approved these changes
Nov 23, 2020
| @@ -1,2 +1 @@ | |||
| Dir[Rails.root.join('lib', 'proofer_mocks', '*')].sort.each { |file| require file } | |||
Contributor
There was a problem hiding this comment.
did this get replaced by something? Or is it that the directory doesn't exist anymore?
Contributor
Author
There was a problem hiding this comment.
Does not exist 🙂
This was referenced Nov 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 6 is going to be somewhat involved, so trying to get as much done as possible before the actual upgrade.
The most significant changes for us will be around autoloading described here and here. The class/module renames are to align with that.
We weren't using 5.2 default configuration, though the only piece we have to disable is a default from 5.0 here.
Rails 6 support was released in rspec-rails 4.0, but works for our current version.