Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/rails-6-prep-part-2-lg-3753
branch
from
8c3fb37 to
4144ce5
Compare
zachmargolis
approved these changes
Nov 24, 2020
| gem 'identity-doc-auth', github: '18F/identity-doc-auth', tag: 'v0.3.0' | ||
| gem 'identity-hostdata', github: '18F/identity-hostdata', tag: 'v0.4.1' | ||
| require File.join(__dir__, 'app', 'services', 'lambda_jobs', 'git_ref.rb') | ||
| require File.join(__dir__, 'lib', 'lambda_jobs', 'git_ref.rb') |
Contributor
There was a problem hiding this comment.
We need to update the Dockerfile that points to this too: https://github.com/18F/identity-idp/blob/master/development.Dockerfile#L12
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4451
Fixes a couple more class names, and ran
rake rails:updateto get some of the config from 5.2 upgrade.Also moves git_ref into
libbecause it shouldn't be autoloaded or reloaded.