Log face match results to events.log (LG-2495)#4018
Merged
zachmargolis merged 3 commits intomasterfrom Aug 7, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Builds on previous work in #4007 and #4001 that update logging to the database)
This PR adds logging to events.log, it's stringing together a few different files so here's what's going on:
Step#callreturns a FormResponse, we would log itAcuant::Responseobjects duck-type FormResponses, but are not actually form responses so the previous check to log would failStep#callwas not returning the result object in most cases at all anywaysAcuant::Responseobjects to be logged (the response objects are already pretty well-behaved about PII)I also added a matcher for FakeAnalytics and to make testing this a little cleaner