Fix ESLint errors in image preview pack file#3918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: As a developer, when I run
yarn run lintI expect no errors, so that I can have confidence in the quality of the code.The changes proposed in this pull request resolve a lint error in the image previews pack.
This occurred as an unfortunate timing overlap between the merges of #3901 and #3914 , where the changes introduced in the latter surfaced new errors in the former.
The changes also bring the added code in line with the previous implementation of
imagePreview:identity-idp/app/javascript/packs/image-preview.js
Line 10 in 748af83