LG-3022: extending auth clients to accept front/back DL images in one call.#3901
Merged
LG-3022: extending auth clients to accept front/back DL images in one call.#3901
Conversation
solipet
changed the title
solipet
force-pushed
the
dprice-lg-3022-one-form-to-submit-them-all
branch
from
8fec481 to
ba4adeb
Compare
jmhooper
reviewed
Jul 13, 2020
aduth
reviewed
Jul 14, 2020
Comment on lines
+30
to
+32
| $('#take_picture').on('click', function() { | ||
| document.getElementById('doc_auth_front_image').click(); | ||
| }); |
Contributor
There was a problem hiding this comment.
I haven't tested to see how this behaves, but seeing as the same ID is being used for both the front and back image, each with a click handler to click on a different element, I've got to imagine there would be some conflict, where both would be clicked.
jmhooper
reviewed
Jul 14, 2020
jmhooper
reviewed
Jul 14, 2020
jmhooper
reviewed
Jul 14, 2020
jmhooper
reviewed
Jul 14, 2020
jmhooper
approved these changes
Jul 14, 2020
Contributor
jmhooper
left a comment
jmhooper
left a comment
There was a problem hiding this comment.
Awesome, I think this one is ready to go then we can move on to selfie 👍
solipet
force-pushed
the
dprice-lg-3022-one-form-to-submit-them-all
branch
from
92d6a4f to
d73a702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're capping this story on merging the front/back image upload (desktop only) into one call so that we can prepare for the switch over to Experian.
As a user, I would like a form that allows me to upload the necessary images so that I can complete my proofing.
AC:
This is in addition to the existing flow, not replacing - need to be able to switch back and forth (feature flag)