Upgrade CodeClimate ESLint engine and resolve errors#3914
Merged
Conversation
Hypothesis: If CodeClimate is attempting to parse this by JSON.parse, then it would fail on syntax https://github.com/codeclimate/codeclimate-eslint/blob/c6856ab6604aa3ed2c2e8bfd285dcdd888082a16/lib/engine_config.js#L48
Hypothesis: CodeClimate doesn't support 7.x and may fail to run in latest version
158283d to
311a523
Compare
Consistency with other channel configuration. Maybe required?
This was referenced Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3909 (comment) for additional context.
By default, CodeClimate uses an older version of ESLint than is installed in the project. It was not adhering to the expected configuration, causing both false positives and false negatives. The changes in this pull request update CodeClimate to use a version of ESLint closer to that which is installed in the application. It includes fixes to all preexisting issues.
Issues were fixed by a combination of:
npx eslint app spec --fixlocationglobal -> Reference from window globalwindow.locationFor all specific changes, note that these rules are inherited largely from Airbnb's coding standard that we follow, and are therefore largely expected.